Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Email and Phone Links to Footer Section! #762

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

Samridhi002
Copy link
Contributor

@Samridhi002 Samridhi002 commented Jun 5, 2024

Description

I have added the links to the E-mail as well as with the phone number, so that when user clicks on them he/she is prompted to his default e-mail client and calling app. I have made these changes on Story Page as well as on Home Page of the website.

Changes:

  • Added a mailto: link to the email address [email protected] on the Story Page and Home Page footers, so that clicking on it opens the user's default email client.
  • Added a tel: link to the phone number on the Story Page and Home Page footers, so that clicking on it opens the user's default phone dialer or calling app.

Title and Issue number

Issue No. : #621
Close #<issue_no>
Close #621

Video/Screenshots (mandatory)

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing

Additional context:

I was earlier facing branch conflict and after updating my forked repository I noticed that all other footer links (FAQs, Terms & Conditions, Privacy Policy, and Contact Us) were already functioning correctly.

##Are you contributing under any Open-source programme ?
GSSoC'24

Copy link

netlify bot commented Jun 5, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 34bfac9
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/6660850180d3070008d922bb
😎 Deploy Preview https://deploy-preview-762--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Samridhi002 Samridhi002 changed the title Added Functional Email and Phone Links to Footer Section Added Email and Phone Links to Footer Section! Jun 5, 2024
@Samridhi002 Samridhi002 changed the title Added Email and Phone Links to Footer Section! feat: Added Email and Phone Links to Footer Section! Jun 5, 2024
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Samridhi002 thanks for the changes

@apu52 apu52 merged commit 6876ff8 into apu52:main Jun 6, 2024
6 of 15 checks passed
@apu52 apu52 added bug Something isn't working level1 gssoc labels Jun 6, 2024
@Samridhi002
Copy link
Contributor Author

@Samridhi002 thanks for the changes

@apu52 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc level1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-functioning links in the footer section of Story Page
2 participants